From: Christoph Hellwig <hch@infradead.org>
To: Nathan Scott <nathans@sgi.com>
Cc: xfs@oss.sgi.com, jeremy@sgi.com
Subject: Re: review: fix remount vs barrier options
Date: Sun, 23 Jul 2006 20:06:50 +0100 [thread overview]
Message-ID: <20060723190650.GA22180@infradead.org> (raw)
In-Reply-To: <20060721152807.D1998769@wobbly.melbourne.sgi.com>
> It finally clicked that we are not clearing the buffer flag
> from a previously written log buffer, even though we'll no
> longer set a new flag into a buffer (due to the mount flag
> being cleared), so we _can_ still issue barrier writes when
> remounted without barriers.
That's true. Ooops.
> This was made more complicated by the way a freshly mounted
> filesystem with 8 log buffers wouldn't show up the problem,
> since we have to slowly cycle through the "clear" log buffers
> before we see the bug. This seems like the simplest fix...
>
> (Hmmm, actually, I wonder if this will also resolve the quota
> log I/O problem that was reported the other day too).
Shouldn't we make sure we clear all flags when reusing a log buffer?
Relying on clearing individual flags seems rather fragile to me.
next prev parent reply other threads:[~2006-07-23 20:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-21 5:28 review: fix remount vs barrier options Nathan Scott
2006-07-21 6:25 ` Timothy Shimmin
2006-07-23 19:06 ` Christoph Hellwig [this message]
2006-07-24 0:01 ` Nathan Scott
2006-07-24 1:27 ` Nathan Scott
2006-07-25 9:44 ` Christoph Hellwig
2006-07-25 22:21 ` Nathan Scott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060723190650.GA22180@infradead.org \
--to=hch@infradead.org \
--cc=jeremy@sgi.com \
--cc=nathans@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox