From: Nathan Scott <nathans@sgi.com>
To: ProfiHost - Stefan Priebe <s.priebe@profihost.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
xfs@oss.sgi.com
Subject: Re: XFS / Quota Bug in 2.6.17.x and 2.6.18x
Date: Fri, 28 Jul 2006 09:42:54 +1000 [thread overview]
Message-ID: <20060728094254.F2196410@wobbly.melbourne.sgi.com> (raw)
In-Reply-To: <44C8A5F1.7060604@profihost.com>; from s.priebe@profihost.com on Thu, Jul 27, 2006 at 01:39:29PM +0200
Hi Stefan,
On Thu, Jul 27, 2006 at 01:39:29PM +0200, ProfiHost - Stefan Priebe wrote:
> Hello!
>
> The crash only occurs if you use quota and IDE without barrier support.
>
> The Problem is, that on a new mount of a root filesystem - the flag
> VFS_RDONLY is set - and so no barrier check is done before checking
> quota. With this patch barrier check is done always. The partition
> should not be mounted at that moment. For mount -o remount, rw or
> something like this it uses another function where VFS_RDONLY is checked.
Ah, I see. The patch isn't quite right, I think we will now need to
also add a test to xfs_mountfs_check_barriers() to ensure the device
beneath us is not bdev_read_only().
I'll add that and get the fix merged, thanks.
cheers.
--
Nathan
prev parent reply other threads:[~2006-07-27 23:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <44C8A5F1.7060604@profihost.com>
[not found] ` <20060727120425.GB6825@martell.zuzino.mipt.ru>
2006-07-27 12:24 ` XFS / Quota Bug in 2.6.17.x and 2.6.18x ProfiHost - Stefan Priebe
2006-07-27 23:42 ` Nathan Scott [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060728094254.F2196410@wobbly.melbourne.sgi.com \
--to=nathans@sgi.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=s.priebe@profihost.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox