public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Nathan Scott <nathans@sgi.com>
To: Timothy Shimmin <tes@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: review: block bogus bulkstat messages, last stage
Date: Fri, 28 Jul 2006 15:22:44 +1000	[thread overview]
Message-ID: <20060728152244.H2196410@wobbly.melbourne.sgi.com> (raw)
In-Reply-To: <44C99C86.2000208@sgi.com>; from tes@sgi.com on Fri, Jul 28, 2006 at 03:11:34PM +1000

On Fri, Jul 28, 2006 at 03:11:34PM +1000, Timothy Shimmin wrote:
> 1. xfs_ialloc.c
> +		xfs_stack_trace();
> What's the stack trace for?
> It is just to give more info after one of the 3 error msgs
> beforehand? Happens in DEBUG. Okay.

Yep, basically just to help figure out how the warning got triggered.
If it gets triggered now, it always indicates a real problem... while
before it was only possibly a problem.

> Seems fine.

Thanks for the review.

cheers.

-- 
Nathan

      reply	other threads:[~2006-07-28  5:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-26  0:15 review: block bogus bulkstat messages, last stage Nathan Scott
2006-07-28  5:11 ` Timothy Shimmin
2006-07-28  5:22   ` Nathan Scott [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060728152244.H2196410@wobbly.melbourne.sgi.com \
    --to=nathans@sgi.com \
    --cc=tes@sgi.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox