From: Nathan Scott <nathans@sgi.com>
To: Greg KH <greg@kroah.com>
Cc: Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>,
xfs@oss.sgi.com
Subject: XFS fix for 2.6.18-rc5
Date: Thu, 10 Aug 2006 15:48:18 +1000 [thread overview]
Message-ID: <20060810154817.A2591606@wobbly.melbourne.sgi.com> (raw)
Hi Greg,
Please pull from:
git://oss.sgi.com:8090/nathans/xfs-rc-2.6
This will update the following files:
fs/xfs/xfs_alloc.c | 103 +++++++++++++++++++++++++++-------------------------
1 files changed, 54 insertions(+), 49 deletions(-)
through these commits:
commit 0e1edbd99994270023cea5afe593f972eb09a778
Author: Nathan Scott <nathans@sgi.com>
Date: Thu Aug 10 14:40:41 2006 +1000
[XFS] Fix xfs_free_extent related NULL pointer dereference.
We recently fixed an out-of-space deadlock in XFS, and part of that fix
involved the addition of the XFS_ALLOC_FLAG_FREEING flag to some of the
space allocator calls to indicate they're freeing space, not allocating
it. There was a missed xfs_alloc_fix_freelist condition test that did not
correctly test "flags". The same test would also test an uninitialised
structure field (args->userdata) and depending on its value either would
or would not return early with a critical buffer pointer set to NULL.
This fixes that up, adds asserts to several places to catch future botches
of this nature, and skips sections of xfs_alloc_fix_freelist that are
irrelevent for the space-freeing case.
SGI-PV: 955303
SGI-Modid: xfs-linux-melb:xfs-kern:26743a
Signed-off-by: Nathan Scott <nathans@sgi.com>
--
Nathan
next reply other threads:[~2006-08-10 5:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-10 5:48 Nathan Scott [this message]
2006-08-10 6:58 ` XFS fix for 2.6.18-rc5 Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060810154817.A2591606@wobbly.melbourne.sgi.com \
--to=nathans@sgi.com \
--cc=akpm@osdl.org \
--cc=greg@kroah.com \
--cc=torvalds@osdl.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox