* [2.6 patch] fs/xfs/xfs_bmap.c:xfs_bmapi(): fix a bug
@ 2006-08-26 15:06 Adrian Bunk
2006-08-28 0:31 ` Nathan Scott
0 siblings, 1 reply; 2+ messages in thread
From: Adrian Bunk @ 2006-08-26 15:06 UTC (permalink / raw)
To: Nathan Scott; +Cc: xfs, linux-kernel
This patch fixes the following bug introduced by commit
39269e29d4aad04252e0debec4c9b01bac16a257:
Since bma.conv is a char and XFS_BMAPI_CONVERT is 0x1000, bma.conv was
always assigned zero.
Spotted by the GNU C compiler (SVN version).
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.18-rc4-mm2/fs/xfs/xfs_bmap.c.old 2006-08-26 03:31:23.000000000 +0200
+++ linux-2.6.18-rc4-mm2/fs/xfs/xfs_bmap.c 2006-08-26 03:31:28.000000000 +0200
@@ -4993,7 +4993,7 @@ xfs_bmapi(
bma.firstblock = *firstblock;
bma.alen = alen;
bma.off = aoff;
- bma.conv = (flags & XFS_BMAPI_CONVERT);
+ bma.conv = !!(flags & XFS_BMAPI_CONVERT);
bma.wasdel = wasdelay;
bma.minlen = minlen;
bma.low = flist->xbf_low;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-08-28 0:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-08-26 15:06 [2.6 patch] fs/xfs/xfs_bmap.c:xfs_bmapi(): fix a bug Adrian Bunk
2006-08-28 0:31 ` Nathan Scott
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox