From: Christoph Hellwig <hch@infradead.org>
To: Nathan Scott <nathans@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: review: change default realtime extsize
Date: Mon, 28 Aug 2006 21:38:39 +0100 [thread overview]
Message-ID: <20060828203839.GA719@infradead.org> (raw)
In-Reply-To: <20060828133132.A3124842@wobbly.melbourne.sgi.com>
On Mon, Aug 28, 2006 at 01:31:32PM +1000, Nathan Scott wrote:
> Hi,
>
> While testing something else recently, I noticed we were always
> creating a large number of unwritten extents during page cache
> writout to the realtime subvolume. It turned out to be because
> of the way we are typically called with page sized allocation
> requests, but we always allocate much more than a page. Back
> when realtime subvols could only use direct I/O this was fine
> (apps typically used larger IO sizes) but now its not so good.
>
> These larger allocations are ending up meaning we need to do many
> additional unwritten extent conversions (i.e. more transactions,
> and more log traffic), which we can easily avoid. Since we have
> a default 4K filesystem blocksize on the data device, there would
> seem to be no harm in matching that on the realtime subvolume, by
> default. This simple mkfs tweak does just that...
That description makes sense, and given that the one-liner diff is
obviously correct. ACK from me.
prev parent reply other threads:[~2006-08-28 21:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-28 3:31 review: change default realtime extsize Nathan Scott
2006-08-28 20:38 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060828203839.GA719@infradead.org \
--to=hch@infradead.org \
--cc=nathans@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox