public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Nathan Scott <nathans@xfs.org>
To: Roger Willcocks <roger@filmlight.ltd.uk>
Cc: xfs@oss.sgi.com
Subject: race in xfs_rename? (fwd)
Date: Wed, 6 Sep 2006 08:34:48 +1000	[thread overview]
Message-ID: <20060906083448.J3365803@wobbly.melbourne.sgi.com> (raw)

Hi Roger,

I'm gonna be rude and fwd your mail to the list - in the hope
someone there will be able to help you.  I'm running out of time
@sgi and have a bunch of stuff still to get done before I skip
outta here - having to look at the xfs_rename locking right now
might just be enough to make my head explode. ;)

cheers.

----- Forwarded message from Roger Willcocks <roger@filmlight.ltd.uk> -----

Date: 05 Sep 2006 14:30:30 +0100
To: nathans@sgi.com
X-Mailer: Ximian Evolution 1.2.2 (1.2.2-4) 
From: Roger Willcocks <roger@filmlight.ltd.uk>
Subject: race in xfs_rename?

Hi Nathan,

I think I must be missing something here:

xfs_rename calls xfs_lock_for_rename, which i-locks the source file and
directory, target directory, and (if it already exists) the target file.

It returns a two-to-four entry list of participating inodes.

xfs_rename unlocks them all, creates a transaction, and then locks them
all again.

Surely while they're unlocked, another processor could jump in and
fiddle with the underlying files and directories?


--
Roger



----- End forwarded message -----

-- 
Nathan

             reply	other threads:[~2006-09-05 22:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-05 22:34 Nathan Scott [this message]
2006-09-06  2:31 ` race in xfs_rename? (fwd) David Chinner
2006-09-08 14:06   ` Roger Willcocks

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060906083448.J3365803@wobbly.melbourne.sgi.com \
    --to=nathans@xfs.org \
    --cc=roger@filmlight.ltd.uk \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox