From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: with ECARTIS (v1.0.0; list xfs); Mon, 11 Sep 2006 17:03:07 -0700 (PDT) Received: from smtp.osdl.org (smtp.osdl.org [65.172.181.4]) by oss.sgi.com (8.12.10/8.12.10/SuSE Linux 0.7) with ESMTP id k8C02dij010106 for ; Mon, 11 Sep 2006 17:02:41 -0700 Date: Mon, 11 Sep 2006 15:53:11 -0700 From: Andrew Morton Subject: Re: 2.6.18-rc6-mm1 'uio_read' redefined, breaks allyesconfig on i386 Message-Id: <20060911155311.270a8fbb.akpm@osdl.org> In-Reply-To: <20060911224520.GJ9335@shell0.pdx.osdl.net> References: <20060911224520.GJ9335@shell0.pdx.osdl.net> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: xfs-bounce@oss.sgi.com Errors-to: xfs-bounce@oss.sgi.com List-Id: xfs To: Judith Lebzelter Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org, Greg KH , linux-xfs@oss.sgi.com On Mon, 11 Sep 2006 15:45:20 -0700 Judith Lebzelter wrote: > Hello, > > I noticed in the 'allyesconfig' build for i386 is not working for 2.6.18-rc6-mm1. > The function 'uio_read' in gregkh-driver-uio.patch has the same name as a > function in fs/xfs/support/move.c. Here is the error message: > > LD drivers/w1/built-in.o > LD drivers/built-in.o > GEN .version > CHK include/linux/compile.h > UPD include/linux/compile.h > CC init/version.o > LD init/built-in.o > LD .tmp_vmlinux1 > drivers/built-in.o(.text+0x6eb597): In function `uio_read': > drivers/uio/uio_dev.c:59: multiple definition of `uio_read' > fs/built-in.o(.text+0x2f4ee8):fs/xfs/support/move.c:26: first defined here > i686-unknown-linux-gnu-ld: Warning: size of symbol `uio_read' changed from 123 in fs/built-in.o to 397 in drivers/built-in.o > make: [.tmp_vmlinux1] Error 1 (ignored) > KSYM .tmp_kallsyms1.S > i686-unknown-linux-gnu-nm: '.tmp_vmlinux1': No such file > No valid symbol. > make: [.tmp_kallsyms1.S] Error 1 (ignored) > Thanks. I'd suggest that XFS is being poorly behaved here. "uio_read" isn't an appropriately named symbol for a filesystem to be exposing.