From: Chris Wedgwood <cw@f00f.org>
To: Tim Shimmin <tes@sgi.com>
Cc: Shailendra Tripathi <stripathi@agami.com>,
Rene Salmon <rsalmon@tulane.edu>,
xfs@oss.sgi.com, Eric Sandeen <sandeen@sandeen.net>
Subject: Re: LVM and XFS cannot set blocksize on block device
Date: Thu, 28 Sep 2006 08:32:18 -0700 [thread overview]
Message-ID: <20060928153218.GA26366@tuatara.stupidest.org> (raw)
In-Reply-To: <451BA2AF.9090703@sgi.com>
On Thu, Sep 28, 2006 at 08:23:43PM +1000, Tim Shimmin wrote:
> I'll have a look soon at passing the mkfs.xfs -s option thru to
> libxfs which is consistent with the existing code.
(following up on something mentioned off the list)
When you do this change please consider *not* making the code fallback
to a different blocksize if the ioctl fails when "-s size=" is given.
The logic here is that if someone clearly wants a specific value and
if that cannot be met it should error out with a suitable message, not
silently do something else.
next prev parent reply other threads:[~2006-09-28 15:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-25 22:11 LVM and XFS cannot set blocksize on block device Rene Salmon
2006-09-26 0:17 ` Chris Wedgwood
2006-09-26 13:58 ` Rene Salmon
2006-09-26 22:40 ` Chris Wedgwood
2006-09-27 11:55 ` Shailendra Tripathi
2006-09-27 13:16 ` Rene Salmon
2006-09-28 10:33 ` Tim Shimmin
2006-09-27 15:48 ` Eric Sandeen
2006-09-28 10:23 ` Tim Shimmin
2006-09-28 15:32 ` Chris Wedgwood [this message]
2006-10-02 7:28 ` Timothy Shimmin
2006-10-03 7:35 ` Timothy Shimmin
2006-10-06 20:36 ` Rene Salmon
2006-10-11 9:59 ` Timothy Shimmin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060928153218.GA26366@tuatara.stupidest.org \
--to=cw@f00f.org \
--cc=rsalmon@tulane.edu \
--cc=sandeen@sandeen.net \
--cc=stripathi@agami.com \
--cc=tes@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox