Re: [PATCH 1/2] Make stuff static

[David Chinner <dgc@sgi.com>]

On Mon, Oct 16, 2006 at 04:34:34PM -0500, Eric Sandeen wrote:
> Eric Sandeen wrote:
> > Timothy Shimmin wrote:
> >> Okay, started looking :-)
> 
> One other thing, based on the bug on osdl today, some of these larger
> newly-static functions should probably be marked noinline to keep gcc
> from doing things we don't want it to...

<grumble>

This is not an obvious compiler hint (compared to, say, likely()) as
the functions gcc automatically inlines changes according to
compiler version, optimisation level and platform. Hence adding
noinline notation will be like playing whack-a-mole and I doubt it
will be consistently used or maintained moving forward. It's the
wrong solution, IMO.

I think we should change the definition of STATIC so we don't have
to poison the code to work around some stupid compiler behaviour.
That is, unless we specifically say "inline" for static functions,
we really mean "noinline".

This will also make debugging easier because we won't get stack
traces that are apparently missing functions and all the associated
pain that this can cause.

Thoughts?

Cheers,

Dave.
-- 
Dave Chinner
Principal Engineer
SGI Australian Software Group