From: "Barry Naujok" <bnaujok@melbourne.sgi.com>
To: 'Roger Willcocks' <roger@filmlight.ltd.uk>, xfs@oss.sgi.com
Subject: RE: LEAFN node level is N -- bogus warning
Date: Tue, 17 Oct 2006 11:25:34 +1000 [thread overview]
Message-ID: <200610170122.LAA26844@larry.melbourne.sgi.com> (raw)
In-Reply-To: <002601c6d687$ad012420$6701a8c0@BODDINGTON>
Hi Roger,
Just to let you know, I now have a filesystem that is displaying this
warning, so I am looking into it in combination with your patch. I'll let
you know how it goes.
Regards,
Barry.
> -----Original Message-----
> From: xfs-bounce@oss.sgi.com [mailto:xfs-bounce@oss.sgi.com]
> On Behalf Of Roger Willcocks
> Sent: Wednesday, 13 September 2006 2:23 AM
> To: xfs@oss.sgi.com
> Subject: LEAFN node level is N -- bogus warning
>
> In xfs_repair / dir2.c there's a check for the 'level' of a
> directory leaf node within the btree hierarchy. A warning
> 'LEAFN node level is N' is generated if the level >= 1.
>
> But leaf nodes don't have a /level/ member, although internal
> nodes do (compare xfs_dir2_leaf_hdr_t and xfs_da_intnode_t).
> xfs_repair is actually testing leaf->hdr.stale - so the
> warning is bogus.
>
> The attached patch removes the test and make the relationship
> between magic numbers and pointer types more explicit.
>
> --
> Roger
>
>
>
prev parent reply other threads:[~2006-10-17 1:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-12 16:22 LEAFN node level is N -- bogus warning Roger Willcocks
2006-10-17 1:25 ` Barry Naujok [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200610170122.LAA26844@larry.melbourne.sgi.com \
--to=bnaujok@melbourne.sgi.com \
--cc=roger@filmlight.ltd.uk \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox