* Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures
[not found] ` <200610211828.33230.arnd@arndb.de>
@ 2006-10-23 2:12 ` David Chinner
0 siblings, 0 replies; only message in thread
From: David Chinner @ 2006-10-23 2:12 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Vasily Tarasov, Christoph Hellwig, Linux Kernel Mailing List,
Andrew Morton, Jan Kara, Dmitry Mishin, Vasily Averin,
Kirill Korotaev, OpenVZ Developers List, xfs
On Sat, Oct 21, 2006 at 06:28:32PM +0200, Arnd Bergmann wrote:
> On a related topic, I just noticed
>
> typedef struct fs_qfilestat {
> __u64 qfs_ino; /* inode number */
> __u64 qfs_nblks; /* number of BBs 512-byte-blks */
> __u32 qfs_nextents; /* number of extents */
> } fs_qfilestat_t;
>
> typedef struct fs_quota_stat {
> __s8 qs_version; /* version number for future changes */
> __u16 qs_flags; /* XFS_QUOTA_{U,P,G}DQ_{ACCT,ENFD} */
> __s8 qs_pad; /* unused */
> fs_qfilestat_t qs_uquota; /* user quota storage information */
> fs_qfilestat_t qs_gquota; /* group quota storage information */
> __u32 qs_incoredqs; /* number of dquots incore */
> __s32 qs_btimelimit; /* limit for blks timer */
> __s32 qs_itimelimit; /* limit for inodes timer */
> __s32 qs_rtbtimelimit;/* limit for rt blks timer */
> __u16 qs_bwarnlimit; /* limit for num warnings */
> __u16 qs_iwarnlimit; /* limit for num warnings */
> } fs_quota_stat_t;
Ah, the XFS quota structures.....
> This one seems to have a more severe problem in x86_64 compat
> mode. I haven't tried it, but isn't everything down from
> gs_gquota aligned differently on i386?
Yes - this is just one of several interfaces into XFS that need compat
handling that don't have them right now.
Cheers,
Dave.
--
Dave Chinner
Principal Engineer
SGI Australian Software Group
^ permalink raw reply [flat|nested] only message in thread