Unexpected inode type 0160000 causes abort of xfs_repair

Unexpected inode type 0160000 causes abort of xfs_repair

[Jonathan Groll]

I'm unsuccesfully trying to repair an XFS filesystem 

xfs_repair /dev/md1 and the same with -L both end with
bad (negative) size -2150115811482766770 on inode 1539849750
cleared inode 1539849750
bad magic number 0x859b on inode 1539849751, resetting magic number
bad version number 0xffffff88 on inode 1539849751, resetting version
number
Unexpected inode type 0160000 inode 1539849751
Aborted

OS: debian sarge (stable)
Kernel: 2.6.15.7
xfsprogs       2.8.11-1

Is there anything I can possibly do?

Many thanks,
Jonathan Groll

Unexpected inode type 0160000 causes abort of xfs_repair

[Jonathan Groll]

I'm unsuccesfully trying to repair an XFS filesystem 

xfs_repair /dev/md1 and the same with -L both end with
bad (negative) size -2150115811482766770 on inode 1539849750
cleared inode 1539849750
bad magic number 0x859b on inode 1539849751, resetting magic number
bad version number 0xffffff88 on inode 1539849751, resetting version
number
Unexpected inode type 0160000 inode 1539849751
Aborted

OS: debian sarge (stable)
Kernel: 2.6.15.7
xfsprogs       2.8.11-1

Is there anything I can possibly do?

Many thanks,
Jonathan Groll

Re: Unexpected inode type 0160000 causes abort of xfs_repair

[Barry Naujok]

[-- Attachment #1: Type: text/plain, Size: 898 bytes --]

Can you try the attached patch and see how xfs_repair goes? 

> -----Original Message-----
> From: xfs-bounce@oss.sgi.com [mailto:xfs-bounce@oss.sgi.com] 
> On Behalf Of Jonathan Groll
> Sent: Thursday, 23 November 2006 7:12 AM
> To: xfs@oss.sgi.com
> Subject: Unexpected inode type 0160000 causes abort of xfs_repair
> 
> I'm unsuccesfully trying to repair an XFS filesystem 
> 
> xfs_repair /dev/md1 and the same with -L both end with
> bad (negative) size -2150115811482766770 on inode 1539849750
> cleared inode 1539849750
> bad magic number 0x859b on inode 1539849751, resetting magic number
> bad version number 0xffffff88 on inode 1539849751, resetting version
> number
> Unexpected inode type 0160000 inode 1539849751
> Aborted
> 
> OS: debian sarge (stable)
> Kernel: 2.6.15.7
> xfsprogs       2.8.11-1
> 
> Is there anything I can possibly do?
> 
> Many thanks,
> Jonathan Groll
> 
> 




[-- Attachment #2: xfs_repair.diff --]
[-- Type: application/octet-stream, Size: 866 bytes --]

--- a/xfsprogs/repair/dinode.c	2006-11-23 11:47:17.000000000 +1100
+++ b/xfsprogs/repair/dinode.c	2006-11-23 11:40:31.219340329 +1100
@@ -2060,11 +2060,21 @@
 		type = XR_INO_FIFO;
 		break;
 	default:
-		type = XR_INO_UNKNOWN;
-		do_warn(_("Unexpected inode type %#o inode %llu\n"),
-			(int) (INT_GET(dinoc->di_mode, ARCH_CONVERT) & S_IFMT), lino);
-		abort();
-		break;
+		retval++;
+		if (!verify_mode)  {
+			do_warn(_("bad inode type %#o inode %llu\n"),
+				(int) (INT_GET(dinoc->di_mode, ARCH_CONVERT) & S_IFMT), lino);
+			if (!no_modify)  
+				*dirty += clear_dinode(mp, dino, lino);
+			else 
+				*dirty = 1;
+			*cleared = 1;
+			*used = is_free;
+		} else if (!uncertain)  {
+			do_warn(_("bad inode type %#o inode %llu\n"),
+				(int) (INT_GET(dinoc->di_mode, ARCH_CONVERT) & S_IFMT), lino);
+		}
+		return 1;
 	}
 
 	/*

Re: Unexpected inode type 0160000 causes abort of xfs_repair

[Chris Wedgwood]

On Wed, Nov 22, 2006 at 10:11:31PM +0200, Jonathan Groll wrote:

> Is there anything I can possibly do?

smash the inode using xfs_db (set mode to 0 should work) and run
repair, it will prune it away for you

Re: Unexpected inode type 0160000 causes abort of xfs_repair

[Jonathan Groll]

On Thu, Nov 23, 2006 at 11:51:11AM +1100, Barry Naujok wrote:
> Can you try the attached patch and see how xfs_repair goes? 

Many thanks, the patch worked like a charm! Is it going to be
incorporated into the package in future?

Luckily I didn't have to blast the inode away, but I suspect that is
exactly what the effect of the patch was ;-)

Thanks again,
Jonathan

RE: Unexpected inode type 0160000 causes abort of xfs_repair

[Barry Naujok]

Yes, this patch will be incorporated in the next xfsprogs update.

And yes, it did blast the inode away, as it wasn't really an inode (or
very very corrupted if it was). 

> -----Original Message-----
> From: Jonathan Groll [mailto:lists@groll.co.za] 
> Sent: Friday, 24 November 2006 12:14 AM
> To: Barry Naujok; xfs@oss.sgi.com
> Subject: Re: Unexpected inode type 0160000 causes abort of xfs_repair
> 
> On Thu, Nov 23, 2006 at 11:51:11AM +1100, Barry Naujok wrote:
> > Can you try the attached patch and see how xfs_repair goes? 
> 
> Many thanks, the patch worked like a charm! Is it going to be
> incorporated into the package in future?
> 
> Luckily I didn't have to blast the inode away, but I suspect that is
> exactly what the effect of the patch was ;-)
> 
> Thanks again,
> Jonathan