From: Christoph Hellwig <hch@infradead.org>
To: Vlad Apostolov <vapo@sgi.com>
Cc: Christoph Hellwig <hch@infradead.org>,
sgi.bugs.xfs@engr.sgi.com, linux-xfs@oss.sgi.com
Subject: Re: TAKE 956783 - xfs_dm_getall_dmattr() doesn't check if the user buffer is at valid address
Date: Wed, 29 Nov 2006 15:11:46 +0000 [thread overview]
Message-ID: <20061129151146.GA4746@infradead.org> (raw)
In-Reply-To: <456B7C1A.90209@sgi.com>
On Tue, Nov 28, 2006 at 11:00:26AM +1100, Vlad Apostolov wrote:
> The fix is actually fine as it gives an early indication (even not complete)
> that the user pointer is bad. There is another problem you are pointing at
> and it is the userspace pointer dereference later on without using
> copy_to_user(). If you have any patch fixing this problem it would be great.
Unfortunately I haven't found my patch, I'm sorry. I have on the other
hand found various old trivial XFS patches of mine that I'll submit.
prev parent reply other threads:[~2006-11-29 15:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-21 6:21 TAKE 956783 - xfs_dm_getall_dmattr() doesn't check if the user buffer is at valid address Vlad Apostolov
2006-11-27 5:58 ` Christoph Hellwig
2006-11-28 0:00 ` Vlad Apostolov
2006-11-29 15:11 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061129151146.GA4746@infradead.org \
--to=hch@infradead.org \
--cc=linux-xfs@oss.sgi.com \
--cc=sgi.bugs.xfs@engr.sgi.com \
--cc=vapo@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox