public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: David Chinner <dgc@sgi.com>
To: Stephen Pollei <stephen.pollei@gmail.com>
Cc: Mike Mattie <codermattie@gmail.com>,
	"linux-kernel @ vger. kernel. org" <linux-kernel@vger.kernel.org>,
	xfs@oss.sgi.com
Subject: Re: "BUG: held lock freed!" lock validator tripped by kswapd & xfs
Date: Mon, 4 Dec 2006 12:35:20 +1100	[thread overview]
Message-ID: <20061204013520.GI44411608@melbourne.sgi.com> (raw)
In-Reply-To: <feed8cdd0612011434n4c025fcbvd9997485d8b35149@mail.gmail.com>

On Fri, Dec 01, 2006 at 02:34:42PM -0800, Stephen Pollei wrote:
> On 12/1/06, Mike Mattie <codermattie@gmail.com> wrote:
> 
> >In an attempt to debug another kernel issue I turned on the lock validator 
> >and
> >managed to generate this report.
> >
> >As a side note the first attempt to boot with the lock validator failed 
> >with
> >a message indicating I had exceeded MAX_LOCK_DEPTH. To get this trace
> >I patched sched.h: MAX_LOCK_DEPTH to 60.
> >
> >Dec  1 08:35:41 reforged [ 3052.513931] =========================
> >Dec  1 08:35:41 reforged [ 3052.513937] [ BUG: held lock freed! ]
> >Dec  1 08:35:41 reforged [ 3052.513939] -------------------------
> >Dec  1 08:35:41 reforged [ 3052.513943] kswapd0/183 is freeing memory
> >c3458000-c3458fff, with a lock still held there! Dec  1 08:35:41
> >reforged [ 3052.513947]  (&(&ip->i_iolock)->mr_lock){....}, at:
> >[<c0222289>] xfs_ilock+0x20/0x75 Dec  1 08:35:41 reforged
> >[ 3052.513959] 28 locks held by kswapd0/183: Dec  1 08:35:41 reforged
> >[ 3052.513961]  #0:  (&(&ip->i_iolock)->mr_lock){....}, at:
> >[<c0222289>] xfs_ilock+0x20/0x75 Dec  1 08:35:41 reforged
> >[ 3052.513968]  #1:  (&(&ip->i_lock)->mr_lock){....}, at: [<c02222bb>]
> >xfs_ilock+0x52/0x75 Dec  1 08:35:41 reforged [ 3052.513975]
> 
> seems to alternate between same two locks. But both c0222289 and
> c02222bb are not between the page(oxfff=4095 or about 4k) which kswapd
> is trying to get rid of.
> I think this trace is on crack somehow.

IIRC, lockdep doesn't understand the xfs inode locks yet. We've
got a patch to fix most of this, but I don't think it's been merged.

Cheers,

Dave
-- 
Dave Chinner
Principal Engineer
SGI Australian Software Group

           reply	other threads:[~2006-12-04  1:36 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <feed8cdd0612011434n4c025fcbvd9997485d8b35149@mail.gmail.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061204013520.GI44411608@melbourne.sgi.com \
    --to=dgc@sgi.com \
    --cc=codermattie@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stephen.pollei@gmail.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox