From: Christoph Hellwig <hch@lst.de>
To: David Chinner <dgc@sgi.com>
Cc: Christoph Hellwig <hch@lst.de>, xfs@oss.sgi.com
Subject: Re: [PATCH] remove v_number
Date: Mon, 4 Dec 2006 12:34:06 +0100 [thread overview]
Message-ID: <20061204113406.GC11074@lst.de> (raw)
In-Reply-To: <20061130003050.GG33919298@melbourne.sgi.com>
On Thu, Nov 30, 2006 at 11:30:50AM +1100, David Chinner wrote:
> On Wed, Nov 29, 2006 at 04:47:29PM +0100, Christoph Hellwig wrote:
> > v_number is unused except for the naming some locks (which is a
> > functionality totally unused by Linux), so remove it and assorted
> > crap. Besides saving two words in struct vnode this also gets rid
> > of a spinlock per inode allocation.
>
> Hmm - given that I've just used the v_number in post-mortem analysis
> of a nasty bug to correlate the sequence of events during a series
> of mkdir operations (i.e. transactions in the incore log buffers,
> the resulting xfs_inodes and some screwed up dentries) that lead to
> a BUG_ON being tripped in d_instantiate.
>
> So, while it appears to be unused, it is _very_ useful for
> determining the SOE that has occurred in certain types of problems.
>
> FWIW, while analysing this crash dump a couple of days ago I was
> wishing that dentries had an equivalent sequence number because
> there is no way to tell what dentry was supposed to be related to
> what inode after it got screwed up...
Putting in sequence counting is trivial using kprobes. Will you put
in this patch after I write you a kprobes modules to do the sequence
numbering?
next prev parent reply other threads:[~2006-12-04 11:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-29 15:47 [PATCH] remove v_number Christoph Hellwig
2006-11-30 0:30 ` David Chinner
2006-12-04 11:34 ` Christoph Hellwig [this message]
2006-12-04 21:56 ` David Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061204113406.GC11074@lst.de \
--to=hch@lst.de \
--cc=dgc@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox