From: David Chinner <dgc@sgi.com>
To: David Chinner <dgc@sgi.com>
Cc: xfs-dev@sgi.com, xfs@oss.sgi.com
Subject: Re: Review: xfs_start_page_writeback should use clear_page_dirty_for_io
Date: Fri, 22 Dec 2006 11:31:40 +1100 [thread overview]
Message-ID: <20061222003140.GN33919298@melbourne.sgi.com> (raw)
In-Reply-To: <20061221235146.GM33919298@melbourne.sgi.com>
On Fri, Dec 22, 2006 at 10:51:46AM +1100, David Chinner wrote:
> As has been discuss on LKML w.r.t to an ext3 corruption bug
> (http://lkml.org/lkml/2006/12/16/164), we should not use clear_page_dirty()
> as it can result in inconsistent state within the VM and is likely
> to go away very soon. Instead, we should be using clear_page_dirty_for_io()
> which does the right thing. Some references:
>
> http://lkml.org/lkml/2006/12/20/204
> http://lkml.org/lkml/2006/12/20/295
> http://lkml.org/lkml/2006/12/20/310
> http://lkml.org/lkml/2006/12/20/362
>
> Linus's patch fixes the corruption seen on ARM, so is likely to be merged
> (potentially as a stable 2.6.19.x fix).
FYI, Linus has already commited his patches and this patch to his git tree.
http://kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=fba2591bf4e418b6c3f9f8794c9dd8fe40ae7bd9
http://kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=921320210bd2ec4f17053d283355b73048ac0e56
Cheers,
Dave.
--
Dave Chinner
Principal Engineer
SGI Australian Software Group
prev parent reply other threads:[~2006-12-22 0:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-21 23:51 Review: xfs_start_page_writeback should use clear_page_dirty_for_io David Chinner
2006-12-22 0:31 ` David Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061222003140.GN33919298@melbourne.sgi.com \
--to=dgc@sgi.com \
--cc=xfs-dev@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox