Re: BUG: warning at mm/truncate.c:60/cancel_dirty_page()

Sami Farin
2007-01-08T13:08:57Z

On Mon, Jan 08, 2007 at 10:04:36 +1100, David Chinner wrote:
> On Sun, Jan 07, 2007 at 02:48:12PM -0800, Andrew Morton wrote:
> > On Mon, 8 Jan 2007 09:23:41 +1100
> > David Chinner <dgc@sgi.com> wrote:
> >
> > > How are you supposed to invalidate a range of pages in a mapping for
> > > this case, then? invalidate_mapping_pages() would appear to be the
> > > candidate (the generic code uses this), but it _skips_ pages that
> > > are already mapped.
> >
> > unmap_mapping_range()?
>
> /me looks at how it's used in invalidate_inode_pages2_range() and
> decides it's easier not to call this directly.
>
> > > So, am I correct in assuming we should be calling invalidate_inode_pages2_range()
> > > instead of truncate_inode_pages()?
> >
> > That would be conventional.
>
> .... in that case the following patch should fix the warning:

I tried dt+strace+cinfo with this patch applied and got no warnings.
Thanks for quick fix.

--
Do what you love because life is too short for anything else.