From: Christoph Hellwig <hch@infradead.org>
To: David Chinner <dgc@sgi.com>
Cc: xfs-dev@sgi.com, xfs@oss.sgi.com
Subject: Re: Review: make growing by >2TB work
Date: Mon, 8 Jan 2007 09:12:18 +0000 [thread overview]
Message-ID: <20070108091218.GB17121@infradead.org> (raw)
In-Reply-To: <20070108044414.GC44411608@melbourne.sgi.com>
On Mon, Jan 08, 2007 at 03:44:14PM +1100, David Chinner wrote:
> Growing a filesystem by > 2TB currently causes an overflow
> in the transaction subsystem. Make transaction deltas and associated
> elements explicitly 64 bit types so that we don't get overflows.
>
> Comments?
Looks good.
>
> - AIL_LOCKINIT(&mp->m_ail_lock, "xfs_ail");
> spinlock_init(&mp->m_sb_lock, "xfs_sb");
> mutex_init(&mp->m_ilock);
> initnsema(&mp->m_growlock, 1, "xfs_grow");
> - /*
> - * Initialize the AIL.
> - */
> - xfs_trans_ail_init(mp);
This seems unrelated (?)
> -xfs_mod_incore_sb(xfs_mount_t *mp, xfs_sb_field_t field, int delta, int rsvd)
> +xfs_mod_incore_sb(xfs_mount_t *mp, xfs_sb_field_t field, int64_t delta, int rsvd)
This seems to be over 80 chars linelength with your patch, just break
the line.
next prev parent reply other threads:[~2007-01-08 9:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-08 4:44 Review: make growing by >2TB work David Chinner
2007-01-08 9:12 ` Christoph Hellwig [this message]
2007-01-08 23:01 ` David Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070108091218.GB17121@infradead.org \
--to=hch@infradead.org \
--cc=dgc@sgi.com \
--cc=xfs-dev@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox