From: dgc@sgi.com (David Chinner)
To: xfs@oss.sgi.com, sgi.bugs.xfs@engr.sgi.com
Subject: TAKE 960028 - XFS tripping bug in cancel_dirty_pages in 2.6.20-rc3
Date: Thu, 11 Jan 2007 17:23:46 +1100 (EST) [thread overview]
Message-ID: <20070111062346.7D6AC58CF82A@chook.melbourne.sgi.com> (raw)
Unmap pages before removing them from the page cache.
The new cancel_dirty_pages() code found that XFS was removing
page from the page cache that had dirty page table entries.
XFS invalidates page cache pages via internal interfaces which
are implemented via truncate_inode_pages which does not remove
the page mapping first.
Switch to using invalidate_inode_pages2_range() which does almost
the same thing except it also removes page table mappings as
expected by cancel_dirty_pages.
Date: Thu Jan 11 17:23:10 AEDT 2007
Workarea: chook.melbourne.sgi.com:/build/dgc/isms/2.6.x-xfs
Inspected by: hch@infradead.org,lachlan
The following file(s) were checked into:
longdrop.melbourne.sgi.com:/isms/linux/2.6.x-xfs-melb
Modid: xfs-linux-melb:xfs-kern:27909a
fs/xfs/linux-2.6/xfs_fs_subr.c - 1.48 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/linux-2.6/xfs_fs_subr.c.diff?r1=text&tr1=1.48&r2=text&tr2=1.47&f=h
- Convert truncate_inode_pages to invalidate_inode_pages2_range
so that page table mappings are removed before we remove the
pages from the page cache.
reply other threads:[~2007-01-11 6:24 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070111062346.7D6AC58CF82A@chook.melbourne.sgi.com \
--to=dgc@sgi.com \
--cc=sgi.bugs.xfs@engr.sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox