From: David Chinner <dgc@sgi.com>
To: Kevin Jamieson <kjamieson@bycast.com>
Cc: xfs@oss.sgi.com, chatz@sgi.com
Subject: Re: Review: fix block reservation to work with per-cpu counters
Date: Tue, 16 Jan 2007 10:47:10 +1100 [thread overview]
Message-ID: <20070115234710.GI44411608@melbourne.sgi.com> (raw)
In-Reply-To: <45ABF2AA.2010209@bycast.com>
On Mon, Jan 15, 2007 at 01:31:22PM -0800, Kevin Jamieson wrote:
> This fails to build on non-SMP systems:
>
> CC [M] fs/xfs/xfs_fsops.o
> fs/xfs/xfs_fsops.c: In function 'xfs_fs_counts':
> fs/xfs/xfs_fsops.c:463: warning: implicit declaration of function
> 'xfs_icsb_sync_counters_flags'
> fs/xfs/xfs_fsops.c:463: error: 'XFS_ICSB_LAZY_COUNT' undeclared (first use
> in this function)
> fs/xfs/xfs_fsops.c:463: error: (Each undeclared identifier is reported only
> once
> fs/xfs/xfs_fsops.c:463: error: for each function it appears in.)
> fs/xfs/xfs_fsops.c: In function 'xfs_reserve_blocks':
> fs/xfs/xfs_fsops.c:525: error: 'XFS_ICSB_SB_LOCKED' undeclared (first use
> in this function)
> make[1]: *** [fs/xfs/xfs_fsops.o] Error 1
> make: *** [fs/xfs/xfs.ko] Error 2
>
>
> The define for not HAVE_PERCPU_SB needs to be changed:
Sorry about that - my fault. This fix looks good - I'll try to find some
time to check this in (I'm at LCA right now and have limited net
access).
Chatz, maybe you could check this in?
Cheers,
Dave.
--
Dave Chinner
Principal Engineer
SGI Australian Software Group
next prev parent reply other threads:[~2007-01-15 23:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-15 21:31 Review: fix block reservation to work with per-cpu counters Kevin Jamieson
2007-01-15 23:47 ` David Chinner [this message]
2007-01-16 12:06 ` David Chatterton
-- strict thread matches above, loose matches on Subject: below --
2007-01-08 6:10 David Chinner
2007-01-08 10:52 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070115234710.GI44411608@melbourne.sgi.com \
--to=dgc@sgi.com \
--cc=chatz@sgi.com \
--cc=kjamieson@bycast.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox