* Re: [xfs-masters] [PATCH} XFS: Remove placeholders for unimplemented functionality.
[not found] ` <45BD7F0A.1000004@sandeen.net>
@ 2007-01-29 7:01 ` Christoph Hellwig
2007-01-29 8:06 ` Robert P. J. Day
1 sibling, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2007-01-29 7:01 UTC (permalink / raw)
To: Eric Sandeen; +Cc: xfs-masters, Linux kernel mailing list, Andrew Morton, dgc
On Sun, Jan 28, 2007 at 10:58:50PM -0600, Eric Sandeen wrote:
> >-#else
> > #define xfs_cap_vset(v,p,sz) (-EOPNOTSUPP)
> > #define xfs_cap_vget(v,p,sz) (-EOPNOTSUPP)
> > #define xfs_cap_vremove(v) (-EOPNOTSUPP)
> > #define _CAP_EXISTS (NULL)
> >-#endif
> >
> > #endif /* __KERNEL__ */
>
> By the time you do this, probably may as well remove the whole file; the
> leftover 4 definitions never seem to be used.
>
> The same may go for xfs_mac.h.
Agreed. As Dave said if we get this functionality on Linux it will most
likely be handled at a different level, so keeping the old IRIX-style hooks
is rather pointless.
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [xfs-masters] [PATCH} XFS: Remove placeholders for unimplemented functionality.
[not found] ` <45BD7F0A.1000004@sandeen.net>
2007-01-29 7:01 ` [xfs-masters] [PATCH} XFS: Remove placeholders for unimplemented functionality Christoph Hellwig
@ 2007-01-29 8:06 ` Robert P. J. Day
1 sibling, 0 replies; 2+ messages in thread
From: Robert P. J. Day @ 2007-01-29 8:06 UTC (permalink / raw)
To: Eric Sandeen; +Cc: xfs-masters, Linux kernel mailing list, Andrew Morton, dgc
On Sun, 28 Jan 2007, Eric Sandeen wrote:
> Robert P. J. Day wrote:
> > Remove a couple kernel config variables (FS_POSIX_CAP and
> > FS_POSIX_MAC) that represent placeholders for unimplemented
> > functionality.
> >
> > Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>
> >
> > ---
>
> ...
>
> > diff --git a/fs/xfs/xfs_cap.h b/fs/xfs/xfs_cap.h
> > index 7a0e482..cfedfd1 100644
> > --- a/fs/xfs/xfs_cap.h
> > +++ b/fs/xfs/xfs_cap.h
>
> ...
>
> > -#else
> > #define xfs_cap_vset(v,p,sz) (-EOPNOTSUPP)
> > #define xfs_cap_vget(v,p,sz) (-EOPNOTSUPP)
> > #define xfs_cap_vremove(v) (-EOPNOTSUPP)
> > #define _CAP_EXISTS (NULL)
> > -#endif
> >
> > #endif /* __KERNEL__ */
>
> By the time you do this, probably may as well remove the whole file;
> the leftover 4 definitions never seem to be used.
>
> The same may go for xfs_mac.h.
>
> -Eric
good point. david chinner (dgc) already mentioned that he'd prefer to
run this through the XFS tree so i'll leave this in his capable hands.
rday
--
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA
http://www.fsdev.dreamhosters.com/wiki/index.php?title=Main_Page
========================================================================
^ permalink raw reply [flat|nested] 2+ messages in thread