public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
* PARTIAL TAKE 960328 - Garbage found in a preallocated file on XFS
@ 2007-01-30  0:58 David Chinner
  0 siblings, 0 replies; only message in thread
From: David Chinner @ 2007-01-30  0:58 UTC (permalink / raw)
  To: xfs, sgi.bugs.xfs

Fix sub-block zeroing for buffered writes into unwritten extents.

When writing less than a filesystem block of data into an unwritten
extent via buffered I/O, __xfs_get_blocks fails to set the buffer
new flag. As a result, the generic code will not zero either edge
of the block resulting in garbage being written to disk either side
of the real data. Set the buffer new state on bufferd writes to
unwritten extents to ensure that zeroing occurs.

Date:  Tue Jan 30 11:57:42 AEDT 2007
Workarea:  chook.melbourne.sgi.com:/build/dgc/isms/2.6.x-xfs
Inspected by:  lachlan

The following file(s) were checked into:
  longdrop.melbourne.sgi.com:/isms/linux/2.6.x-xfs-melb


Modid:  xfs-linux-melb:xfs-kern:28000a
fs/xfs/linux-2.6/xfs_aops.c - 1.140 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/linux-2.6/xfs_aops.c.diff?r1=text&tr1=1.140&r2=text&tr2=1.139&f=h
	- Set the buffer_new state when writing into unwritten extents so that
	  sub-block zeroing will occur for buffered writes if necessary.

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2007-01-30  0:59 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-01-30  0:58 PARTIAL TAKE 960328 - Garbage found in a preallocated file on XFS David Chinner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox