From: David Chinner <dgc@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: David Chinner <dgc@sgi.com>, xfs-dev@sgi.com, xfs@oss.sgi.com
Subject: Re: Review: Don't use kmap() in xfs_iozero().
Date: Sat, 3 Feb 2007 00:39:41 +1100 [thread overview]
Message-ID: <20070202133941.GW33919298@melbourne.sgi.com> (raw)
In-Reply-To: <20070202114830.GB23187@infradead.org>
On Fri, Feb 02, 2007 at 11:48:30AM +0000, Christoph Hellwig wrote:
> On Fri, Feb 02, 2007 at 04:40:44PM +1100, David Chinner wrote:
> > kmap is inefficient and does scale well. kmap_atomic() is a better
> > choice. Use the generic wrapper function instead of open coding the
> > kmap-memset-dcache flush-kumap stuff. Suggested by Andrew Morton.
> >
> > Comments?
>
> Looks good.
>
> > + memclear_highpage_flush(page, (unsigned int)offset, bytes);
>
> Do you need the cast here? An unsigned long should be automatically
> demoted to an unsigned int when passing it as an argument.
Even on 64 bit platforms? I just added an explicit cast as a matter
of avoiding potential gcc warnings on other platforms/compiler
versions. Maybe I'm just being paranoid and I can remove it?
Cheers,
Dave.
--
Dave Chinner
Principal Engineer
SGI Australian Software Group
next prev parent reply other threads:[~2007-02-02 13:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-02 5:40 Review: Don't use kmap() in xfs_iozero() David Chinner
2007-02-02 11:48 ` Christoph Hellwig
2007-02-02 13:39 ` David Chinner [this message]
2007-02-02 18:06 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070202133941.GW33919298@melbourne.sgi.com \
--to=dgc@sgi.com \
--cc=hch@infradead.org \
--cc=xfs-dev@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox