From: Christoph Hellwig <hch@infradead.org>
To: David Chinner <dgc@sgi.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs-dev@sgi.com, xfs@oss.sgi.com
Subject: Re: Review: Don't use kmap() in xfs_iozero().
Date: Fri, 2 Feb 2007 18:06:14 +0000 [thread overview]
Message-ID: <20070202180614.GA13938@infradead.org> (raw)
In-Reply-To: <20070202133941.GW33919298@melbourne.sgi.com>
On Sat, Feb 03, 2007 at 12:39:41AM +1100, David Chinner wrote:
> Even on 64 bit platforms? I just added an explicit cast as a matter
> of avoiding potential gcc warnings on other platforms/compiler
> versions. Maybe I'm just being paranoid and I can remove it?
Yes, it's fine on 64bit platforms aswell - I just built my equivalent
buffer.c changes on 64bit powerpc and we have lots of similar cases
all over the tree.
prev parent reply other threads:[~2007-02-02 18:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-02 5:40 Review: Don't use kmap() in xfs_iozero() David Chinner
2007-02-02 11:48 ` Christoph Hellwig
2007-02-02 13:39 ` David Chinner
2007-02-02 18:06 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070202180614.GA13938@infradead.org \
--to=hch@infradead.org \
--cc=dgc@sgi.com \
--cc=xfs-dev@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox