From: David Chinner <dgc@sgi.com>
To: Nathan Scott <nscott@aconex.com>
Cc: Christoph Hellwig <hch@infradead.org>,
David Chinner <dgc@sgi.com>,
xfs-dev@sgi.com, xfs@oss.sgi.com
Subject: Re: Review: freezing sometimes leaves the log dirty
Date: Mon, 5 Feb 2007 10:45:15 +1100 [thread overview]
Message-ID: <20070204234515.GI44411608@melbourne.sgi.com> (raw)
In-Reply-To: <1170626215.18017.394.camel@edge>
On Mon, Feb 05, 2007 at 08:56:55AM +1100, Nathan Scott wrote:
> On Fri, 2007-02-02 at 11:46 +0000, Christoph Hellwig wrote:
> > On Wed, Jan 31, 2007 at 09:03:26AM +1100, David Chinner wrote:
> > > + /* flush inodes and push all remaining buffers out to disk */
> > > + xfs_quiesce_fs(mp);
> > > +
> > > + BUG_ON(atomic_read(&mp->m_active_trans) > 0);
> > > +
> >
> > xfs_vfsops.c is considered common code, so you should probably use
> > ASSERT here, not BUG_ON.
>
> There's also an ASSERT_ALWAYS macro IIRC, if you want the equivalent
> functionality of BUG_ON (i.e. always check).
True, I forgot about that one. Thx, Nathan....
Cheers,
Dave.
--
Dave Chinner
Principal Engineer
SGI Australian Software Group
prev parent reply other threads:[~2007-02-04 23:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-30 22:03 Review: freezing sometimes leaves the log dirty David Chinner
2007-02-01 6:52 ` Donald Douwsma
2007-02-02 11:46 ` Christoph Hellwig
2007-02-02 14:07 ` David Chinner
2007-02-05 21:02 ` David Chinner
2007-02-05 21:09 ` Christoph Hellwig
2007-02-04 21:56 ` Nathan Scott
2007-02-04 23:45 ` David Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070204234515.GI44411608@melbourne.sgi.com \
--to=dgc@sgi.com \
--cc=hch@infradead.org \
--cc=nscott@aconex.com \
--cc=xfs-dev@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox