From: Christoph Hellwig <hch@infradead.org>
To: Barry Naujok <bnaujok@melbourne.sgi.com>
Cc: xfs@oss.sgi.com, 'xfs-dev' <xfs-dev@sgi.com>
Subject: Re: [PATCH] xfs_repair - move realtime extent processing to a separate function
Date: Fri, 13 Apr 2007 08:26:47 +0100 [thread overview]
Message-ID: <20070413072647.GC20326@infradead.org> (raw)
In-Reply-To: <200704130415.OAA16550@larry.melbourne.sgi.com>
On Fri, Apr 13, 2007 at 02:22:10PM +1000, Barry Naujok wrote:
> While changing the process_bmbt_reclist_int() function, I observed a
> realtime check inside the block map get/set state loop which is quite
> CPU intensive. Upon further investigation, this loop is not used at
> all for realtime extents and that the two types of extents are pretty
> much processed exclusively.
>
> So, I simplified the functionality by moving the realtime extent
> processing into it's own function and fixing a bug at the same time
> when it comes to realtime inodes with attributes (it was comparing
> attr extents to the realtime volume bmap instead of the normal bmap).
Nice cleanup, looks good.
prev parent reply other threads:[~2007-04-13 8:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-13 4:22 [PATCH] xfs_repair - move realtime extent processing to a separate function Barry Naujok
2007-04-13 7:26 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070413072647.GC20326@infradead.org \
--to=hch@infradead.org \
--cc=bnaujok@melbourne.sgi.com \
--cc=xfs-dev@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox