From: David Chinner <dgc@sgi.com>
To: Christoph Hellwig <hch@lst.de>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] remove various useless min/max macros
Date: Thu, 19 Apr 2007 09:50:56 +1000 [thread overview]
Message-ID: <20070418235056.GJ48531920@melbourne.sgi.com> (raw)
In-Reply-To: <20070418175730.GA18315@lst.de>
On Wed, Apr 18, 2007 at 07:57:30PM +0200, Christoph Hellwig wrote:
> xfs_btree.h has various macros to calculate a min/max after casting
> it's arguments to a specific type. This can be done much simpler
> by using min_t/max_t with the type as first argument.
Sure, but I NACKed that last October for good reason.
http://marc.info/?t=116116017600003&r=1&w=2
Specifically:
http://marc.info/?l=linux-kernel&m=116122285309389&w=2
I still have no objection to changing the implementation of these
macros or even changing them to non-shouting static inlines but
I don't want them removed....
Cheers,
Dave.
--
Dave Chinner
Principal Engineer
SGI Australian Software Group
next prev parent reply other threads:[~2007-04-18 23:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-18 17:57 [PATCH] remove various useless min/max macros Christoph Hellwig
2007-04-18 23:50 ` David Chinner [this message]
2007-04-22 14:35 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070418235056.GJ48531920@melbourne.sgi.com \
--to=dgc@sgi.com \
--cc=hch@lst.de \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox