From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Christian Kujau <lists@nerdbynature.de>, xfs@oss.sgi.com
Subject: Re: possible recursive locking detected
Date: Mon, 23 Apr 2007 22:19:52 +0100 [thread overview]
Message-ID: <20070423211952.GA13572@infradead.org> (raw)
In-Reply-To: <462D0D23.7010803@sandeen.net>
On Mon, Apr 23, 2007 at 02:46:43PM -0500, Eric Sandeen wrote:
> Christian Kujau wrote:
> > Hi there,
> >
> > On Mon, April 2, 2007 19:18, Christian Kujau wrote:
> >> when I enabled a few more debug-options in the kernel (vanilla
> >> 2.6.21-rc5), I came across:
> >>
> >> [ INFO: possible recursive locking detected ]
> >> 2.6.21-rc5 #2
> >
> > The same happened with -rc7, see below. Can anyone comment if this
> > is/could lead to a problem?
> >
>
> The consensus seems to be that it is cosmetic.
It's not really cosmetic. It means i_lock and i_iolock are beeing
acquired without an order that is detectable by lockdep. At the very
first it means annotations for lockdep are missing, because acquiring
two per-inode locks at the same time is a basic fact in unix filesystems.
But deeper than that the rules for taking both locks are not very well
defined in XFS. These rules at least need documentation in form of
lockdep annotations, and possibly some fixes and cleanups around the
more dirty areas like xfs_lock_for_rename() or xfs_lock_dir_and_entry()
next prev parent reply other threads:[~2007-04-23 21:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-02 18:18 possible recursive locking detected Christian Kujau
2007-04-23 16:08 ` Christian Kujau
2007-04-23 19:46 ` Eric Sandeen
2007-04-23 21:19 ` Christoph Hellwig [this message]
2007-04-24 6:46 ` Christian Kujau
-- strict thread matches above, loose matches on Subject: below --
2007-05-16 14:50 Bernd Schubert
2007-05-16 17:35 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070423211952.GA13572@infradead.org \
--to=hch@infradead.org \
--cc=lists@nerdbynature.de \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox