From: Christoph Hellwig <hch@infradead.org>
To: David Chinner <dgc@sgi.com>
Cc: xfs-dev <xfs-dev@sgi.com>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: review: don't hold ilock when calling vn_iowait
Date: Mon, 23 Apr 2007 22:43:38 +0100 [thread overview]
Message-ID: <20070423214338.GA17561@infradead.org> (raw)
In-Reply-To: <20070422230303.GX32602149@melbourne.sgi.com>
On Mon, Apr 23, 2007 at 09:03:03AM +1000, David Chinner wrote:
>
> Regression introduced by recent freezing fixes - we should
> not hold the ilock while waiting for I/O completion.
Looks good, and actually simplies the twisted maze the xfs_sync_inodes is
a little bit. And the missing IPOINTER_INSERT in the SYNC_CLOSE case
looks like an actual bugfix.
Of course in the end I'd still like to see all pagecache-writeout to
be driven by sync_sb_inodes() instead of the fs code, but it'll probably
take a little longer until that is done.
next prev parent reply other threads:[~2007-04-23 21:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-22 23:03 review: don't hold ilock when calling vn_iowait David Chinner
2007-04-23 21:43 ` Christoph Hellwig [this message]
2007-04-23 23:17 ` David Chinner
2007-04-24 2:00 ` Timothy Shimmin
2007-04-24 3:08 ` David Chinner
2007-04-24 9:10 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070423214338.GA17561@infradead.org \
--to=hch@infradead.org \
--cc=dgc@sgi.com \
--cc=xfs-dev@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox