From: David Chinner <dgc@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: David Chinner <dgc@sgi.com>,
gnb@sgi.com, xfs-oss <xfs@oss.sgi.com>,
nfs@lists.sourceforge.net
Subject: Re: review: don't block non-blocking writes when frozen
Date: Tue, 24 Apr 2007 09:13:37 +1000 [thread overview]
Message-ID: <20070423231337.GN32602149@melbourne.sgi.com> (raw)
In-Reply-To: <20070423212715.GF13572@infradead.org>
On Mon, Apr 23, 2007 at 10:27:15PM +0100, Christoph Hellwig wrote:
> On Mon, Apr 23, 2007 at 10:26:16AM +1000, David Chinner wrote:
> >
> > Prevent nfsds for blocking trying to write to a frozen filesystem
> > or a filesystem in the process of freezing.
>
> Looks good for trees actually having support for non-blocking file
> I/O, which doesn't include mainline. (So please don't send this
> upstead)
Yeah - you NACKed that a year ago based on the fact it would never
get used by mainline code:
http://marc.info/?l=linux-nfs&m=114683005119982&w=2
So, given the catch-22 you've just presented us can we revisit the
nfsd non-blocking I/O issue again? This affects anyone using DM
snapshots on their NFS servers and has nothing to do with HSMs
or DMAPI...
FWIW, you can still do non-blocking userspace I/O to a file, so this
XFS patch is still valid for mainline (that's how I tested it).
Cheers,
Dave.
--
Dave Chinner
Principal Engineer
SGI Australian Software Group
next prev parent reply other threads:[~2007-04-23 23:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-23 0:26 review: don't block non-blocking writes when frozen David Chinner
2007-04-23 21:27 ` Christoph Hellwig
2007-04-23 23:13 ` David Chinner [this message]
2007-04-24 14:55 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070423231337.GN32602149@melbourne.sgi.com \
--to=dgc@sgi.com \
--cc=gnb@sgi.com \
--cc=hch@infradead.org \
--cc=nfs@lists.sourceforge.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox