* Review - flush blockdev on close
@ 2007-04-24 1:42 David Chinner
2007-04-24 8:56 ` Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: David Chinner @ 2007-04-24 1:42 UTC (permalink / raw)
To: xfs-dev; +Cc: xfs-oss
As suggested by Christoph, we probably should flush the block
device as we complete the process of unmounting the filesystem.
Patch attached.
Cheers,
Dave.
--
Dave Chinner
Principal Engineer
SGI Australian Software Group
---
fs/xfs/linux-2.6/xfs_buf.c | 1 +
1 file changed, 1 insertion(+)
Index: 2.6.x-xfs-new/fs/xfs/linux-2.6/xfs_buf.c
===================================================================
--- 2.6.x-xfs-new.orig/fs/xfs/linux-2.6/xfs_buf.c 2007-04-24 09:32:22.000000000 +1000
+++ 2.6.x-xfs-new/fs/xfs/linux-2.6/xfs_buf.c 2007-04-24 11:12:42.181361346 +1000
@@ -1464,6 +1464,7 @@ xfs_free_buftarg(
int external)
{
xfs_flush_buftarg(btp, 1);
+ xfs_blkdev_issue_flush(btp);
if (external)
xfs_blkdev_put(btp->bt_bdev);
xfs_free_bufhash(btp);
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: Review - flush blockdev on close
2007-04-24 1:42 Review - flush blockdev on close David Chinner
@ 2007-04-24 8:56 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2007-04-24 8:56 UTC (permalink / raw)
To: David Chinner; +Cc: xfs-dev, xfs-oss
On Tue, Apr 24, 2007 at 11:42:49AM +1000, David Chinner wrote:
>
> As suggested by Christoph, we probably should flush the block
> device as we complete the process of unmounting the filesystem.
> Patch attached.
Looks good.
>
> Index: 2.6.x-xfs-new/fs/xfs/linux-2.6/xfs_buf.c
> ===================================================================
> --- 2.6.x-xfs-new.orig/fs/xfs/linux-2.6/xfs_buf.c 2007-04-24 09:32:22.000000000 +1000
> +++ 2.6.x-xfs-new/fs/xfs/linux-2.6/xfs_buf.c 2007-04-24 11:12:42.181361346 +1000
> @@ -1464,6 +1464,7 @@ xfs_free_buftarg(
> int external)
> {
> xfs_flush_buftarg(btp, 1);
> + xfs_blkdev_issue_flush(btp);
> if (external)
> xfs_blkdev_put(btp->bt_bdev);
> xfs_free_bufhash(btp);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-04-24 9:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-04-24 1:42 Review - flush blockdev on close David Chinner
2007-04-24 8:56 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox