From: Christoph Hellwig <hch@infradead.org>
To: David Chinner <dgc@sgi.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs-dev <xfs-dev@sgi.com>,
xfs-oss <xfs@oss.sgi.com>
Subject: Re: review [1 of 3]: lazy superblock counters - core kernel
Date: Tue, 24 Apr 2007 09:51:47 +0100 [thread overview]
Message-ID: <20070424085147.GA28820@infradead.org> (raw)
In-Reply-To: <20070424012808.GD48531920@melbourne.sgi.com>
On Tue, Apr 24, 2007 at 11:28:08AM +1000, David Chinner wrote:
> > This is really quite nasty. Should we at least force a cache flush here?
>
> Ok, so the patch I sent out was an older version that had a very similar
> name to the current patch in my series (xfs-lazy-sb vs xfs_lazy_sb).
> This code doesn't exist in the version I should have sent out.
>
> The latest version, plus the changes suggested here and with the
> second patch folded back into it is attached.
Looks like in the new code we simply ignore log reservation
failures in xfs_log_sbcount?
Otherwise this looks good to me.
converting all sb feature checks to use the inlines would be
a nice cleanup opportunity for someone bored :)
next prev parent reply other threads:[~2007-04-24 9:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-19 23:15 review [1 of 3]: lazy superblock counters - core kernel David Chinner
2007-04-23 22:00 ` Christoph Hellwig
2007-04-23 22:16 ` David Chinner
2007-04-23 22:23 ` Christoph Hellwig
2007-04-23 23:20 ` David Chinner
2007-04-24 1:28 ` David Chinner
2007-04-24 8:51 ` Christoph Hellwig [this message]
2007-04-24 14:16 ` David Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070424085147.GA28820@infradead.org \
--to=hch@infradead.org \
--cc=dgc@sgi.com \
--cc=xfs-dev@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox