From: Christoph Hellwig <hch@infradead.org>
To: David Chinner <dgc@sgi.com>
Cc: xfs-dev <xfs-dev@sgi.com>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: Review - flush blockdev on close
Date: Tue, 24 Apr 2007 09:56:47 +0100 [thread overview]
Message-ID: <20070424085647.GB28820@infradead.org> (raw)
In-Reply-To: <20070424014249.GF48531920@melbourne.sgi.com>
On Tue, Apr 24, 2007 at 11:42:49AM +1000, David Chinner wrote:
>
> As suggested by Christoph, we probably should flush the block
> device as we complete the process of unmounting the filesystem.
> Patch attached.
Looks good.
>
> Index: 2.6.x-xfs-new/fs/xfs/linux-2.6/xfs_buf.c
> ===================================================================
> --- 2.6.x-xfs-new.orig/fs/xfs/linux-2.6/xfs_buf.c 2007-04-24 09:32:22.000000000 +1000
> +++ 2.6.x-xfs-new/fs/xfs/linux-2.6/xfs_buf.c 2007-04-24 11:12:42.181361346 +1000
> @@ -1464,6 +1464,7 @@ xfs_free_buftarg(
> int external)
> {
> xfs_flush_buftarg(btp, 1);
> + xfs_blkdev_issue_flush(btp);
> if (external)
> xfs_blkdev_put(btp->bt_bdev);
> xfs_free_bufhash(btp);
prev parent reply other threads:[~2007-04-24 9:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-24 1:42 Review - flush blockdev on close David Chinner
2007-04-24 8:56 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070424085647.GB28820@infradead.org \
--to=hch@infradead.org \
--cc=dgc@sgi.com \
--cc=xfs-dev@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox