From: Christoph Hellwig <hch@infradead.org>
To: David Chinner <dgc@sgi.com>
Cc: Timothy Shimmin <tes@sgi.com>,
Christoph Hellwig <hch@infradead.org>, xfs-dev <xfs-dev@sgi.com>,
xfs-oss <xfs@oss.sgi.com>
Subject: Re: review: don't hold ilock when calling vn_iowait
Date: Tue, 24 Apr 2007 10:10:00 +0100 [thread overview]
Message-ID: <20070424091000.GA31652@infradead.org> (raw)
In-Reply-To: <20070424030826.GG48531920@melbourne.sgi.com>
On Tue, Apr 24, 2007 at 01:08:26PM +1000, David Chinner wrote:
> > It would be nice if this could be clearer somehow.
>
> Yes, we should be looking to rip all this cruft out because most of
> it is redundant - the generic inode writeback does most of this
> for us anyway.
In theory it does the same thing. The problem is that it's really
hard to verify.
Btw, before starting with this bit there's another item on my TODO
list to simplify xfs_sync_inodes, and that's getting rid
of the vp == NULL case totally. Per definition all vp == NULL
inodes are on mp->m_del_inodes. So instead of letting xfs_sync_inodes
deals with them we should always call into xfs_finish_reclaim_all
after cleaning the latter up a little and veryfing we get
the same behaviour.
prev parent reply other threads:[~2007-04-24 9:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-22 23:03 review: don't hold ilock when calling vn_iowait David Chinner
2007-04-23 21:43 ` Christoph Hellwig
2007-04-23 23:17 ` David Chinner
2007-04-24 2:00 ` Timothy Shimmin
2007-04-24 3:08 ` David Chinner
2007-04-24 9:10 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070424091000.GA31652@infradead.org \
--to=hch@infradead.org \
--cc=dgc@sgi.com \
--cc=tes@sgi.com \
--cc=xfs-dev@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox