Re: [patch 1/3] Fix XFS_IOC_FSGEOMETRY_V1 in compat mode

Arnd Bergmann
2007-05-30T22:02:41Z

On Wednesday 30 May 2007, Chris Wedgwood wrote:
>
> On Wed, May 30, 2007 at 02:59:55PM +0200, Michal Marek wrote:
>
> > +typedef struct xfs_fsop_geom_v132 {
>
> wouldn't xfs_fsop_geom_v1_32
>                          ^
>
> > +     __u32           blocksize;      /* filesystem (data) block size */
>
> [...]
>
> > +     __u32           dirblocksize;   /* directory block size, bytes  */
> > +} __attribute__((packed)) xfs_fsop_geom_v132_t;
>
> and xfs_fsop_geom_v1_32_t
>                     ^
>
> read better there?

Actually, the current convention would be struct compat_xfs_fsop_geom_v1
and compat_xfs_fsop_geom_v1_t.