From: Christoph Hellwig <hch@infradead.org>
To: Timothy Shimmin <tes@sgi.com>
Cc: David Chinner <dgc@sgi.com>, Michal Marek <mmarek@suse.cz>,
xfs@oss.sgi.com
Subject: Re: [patch 1/3] Fix XFS_IOC_FSGEOMETRY_V1 in compat mode
Date: Mon, 4 Jun 2007 15:56:16 +0100 [thread overview]
Message-ID: <20070604145616.GA28425@infradead.org> (raw)
In-Reply-To: <0C1BF59AD81186689933280E@timothy-shimmins-power-mac-g5.local>
On Fri, Jun 01, 2007 at 02:39:48PM +1000, Timothy Shimmin wrote:
>
>
> --On 31 May 2007 11:26:15 PM +1000 David Chinner <dgc@sgi.com> wrote:
> >>Who would want to use XFS_IOC_FSGEOMETRY_V1?
> >>
> >>Okay it turns out a whole bunch of our xfs-cmds :-)
> >>(Such as xfsdump as Michal mentioned)
> >>On Sep/2002, Nathan changed a bunch of them to use v1.
> >> xfsprogs-2.3.0 (03 September 2002)
> >> - Several changes to geometry ioctl callers which will make
> >> the tools useable on older kernel versions too.
> >>So he did this so that new tools would work on the older kernels which
> >>didn't support the new geom version.
> >>So I guess we are stuck with v1 now.
> >
> >Not necessarily - we could change the tools to use v4, and if that
> >didn't exist, then try v1. That way we don't need to support v1 in
> >linux, and the tools still run on old kernels.....
> >
> The problem with that is the old tools won't run on new kernels.
> If you get a new kernel and use an old xfsdump then you are out of luck.
> Not sure if we want to require people to bump up to new userspace for this.
Yeah, we need to keep supporting this for a while. Fortunately this
compat handler is rather trivial.
next prev parent reply other threads:[~2007-06-04 14:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-30 12:59 [patch 0/3] Fix for XFS compat ioctls Michal Marek
2007-05-30 12:59 ` [patch 1/3] Fix XFS_IOC_FSGEOMETRY_V1 in compat mode Michal Marek
2007-05-30 17:05 ` Chris Wedgwood
2007-05-30 21:48 ` Arnd Bergmann
2007-05-31 8:10 ` Michal Marek
2007-05-31 2:30 ` David Chinner
2007-05-31 7:22 ` Timothy Shimmin
2007-05-31 13:26 ` David Chinner
2007-06-01 4:39 ` Timothy Shimmin
2007-06-04 14:56 ` Christoph Hellwig [this message]
2007-05-30 12:59 ` [patch 2/3] Fix XFS_IOC_*_TO_HANDLE and XFS_IOC_{OPEN,READLINK}_BY_HANDLE " Michal Marek
2007-05-31 2:36 ` David Chinner
2007-05-30 12:59 ` [patch 3/3] Fix XFS_IOC_FSBULKSTAT{,_SINGLE} and XFS_IOC_FSINUMBERS " Michal Marek
2007-05-31 6:37 ` David Chinner
2007-05-31 8:52 ` Michal Marek
2007-05-31 13:03 ` David Chinner
2007-05-31 7:06 ` Arnd Bergmann
-- strict thread matches above, loose matches on Subject: below --
2007-06-19 13:25 [patch 0/3] Fix for XFS compat ioctls (try2) mmarek
2007-06-19 13:25 ` [patch 1/3] Fix XFS_IOC_FSGEOMETRY_V1 in compat mode mmarek
2007-06-28 3:06 ` David Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070604145616.GA28425@infradead.org \
--to=hch@infradead.org \
--cc=dgc@sgi.com \
--cc=mmarek@suse.cz \
--cc=tes@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox