From: Christoph Hellwig <hch@infradead.org>
To: David Chinner <dgc@sgi.com>
Cc: xfs-dev <xfs-dev@sgi.com>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: Review: remount read-only path is as broken as freezing was....
Date: Mon, 4 Jun 2007 16:08:28 +0100 [thread overview]
Message-ID: <20070604150828.GB28425@infradead.org> (raw)
In-Reply-To: <20070604051433.GP85884050@sgi.com>
On Mon, Jun 04, 2007 at 03:14:33PM +1000, David Chinner wrote:
>
> I recently had a remount,ro test fail in a way I had previously
> only seen freezing fail. That is, it failed because we still
> had active transactions after calling xfs_quiesce_fs(). Further
> investigation shows that this path is broken in the same ways
> that the xfs freeze path was broken (and recently fixed).
Actually it became more broken due to the fix changing things
a little.
In general a mount -o ro should be similar to a quience in
most ways, so the closer we can get them the better. The patch
looks good to me. One thing is that SYNC_INODE_QUIESCE should
probably get a more descriptive name and a comment explaining
why it's needed for quience (we want inodes updated not only in
the log) and why not for remount r/o (because no one cares for that
in this case)
prev parent reply other threads:[~2007-06-04 15:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-04 5:14 Review: remount read-only path is as broken as freezing was David Chinner
2007-06-04 15:08 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070604150828.GB28425@infradead.org \
--to=hch@infradead.org \
--cc=dgc@sgi.com \
--cc=xfs-dev@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox