From: Christoph Hellwig <hch@infradead.org>
To: David Chinner <dgc@sgi.com>
Cc: xfs-dev <xfs-dev@sgi.com>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: Review: factor extracting extent size hints from the inode
Date: Mon, 4 Jun 2007 16:10:34 +0100 [thread overview]
Message-ID: <20070604151034.GC28425@infradead.org> (raw)
In-Reply-To: <20070604052333.GR85884050@sgi.com>
On Mon, Jun 04, 2007 at 03:23:33PM +1000, David Chinner wrote:
> Replace frequently repeated, open coded extraction of the
> extent size hint from the xfs_inode with a single helper
> function.
Looks good, but I'd suggest not putting in the unlikelys. Realtime
or alignment are perfectly normal codepaths and hardcoding them to
be predicted not taken sounds like a bad idea. unlilely should be
limited to exception error handling code.
next prev parent reply other threads:[~2007-06-04 15:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-04 5:23 Review: factor extracting extent size hints from the inode David Chinner
2007-06-04 15:10 ` Christoph Hellwig [this message]
2007-06-12 5:13 ` Vlad Apostolov
2007-06-12 6:08 ` David Chinner
2007-06-12 6:39 ` Nathan Scott
2007-06-12 9:49 ` David Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070604151034.GC28425@infradead.org \
--to=hch@infradead.org \
--cc=dgc@sgi.com \
--cc=xfs-dev@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox