From: David Chinner <dgc@sgi.com>
To: Tim Shimmin <tes@sgi.com>
Cc: xfs-dev@sgi.com, xfs@oss.sgi.com
Subject: Re: review: xfs_growfs_data_private() not logging agf length change
Date: Thu, 7 Jun 2007 17:30:34 +1000 [thread overview]
Message-ID: <20070607073034.GP86004887@sgi.com> (raw)
In-Reply-To: <4667ADAF.7000904@sgi.com>
On Thu, Jun 07, 2007 at 05:03:11PM +1000, Tim Shimmin wrote:
> Looks like we forgot to log the agf_length change here.
>
> (cut 'n' pasted patch)
>
> --Tim
>
> ===========================================================================
> Index: fs/xfs/xfs_fsops.c
> ===========================================================================
>
> --- a/fs/xfs/xfs_fsops.c 2007-04-17 18:02:46.000000000 +1000
> +++ b/fs/xfs/xfs_fsops.c 2007-04-17 17:59:44.467987572 +1000
> @@ -328,6 +328,7 @@ xfs_growfs_data_private(
> be32_add(&agf->agf_length, new);
> ASSERT(be32_to_cpu(agf->agf_length) ==
> be32_to_cpu(agi->agi_length));
> + xfs_alloc_log_agf(tp, bp, XFS_AGF_LENGTH);
> /*
> * Free the new space.
> */
Yup, looks ok to me.
Cheers,
Dave.
--
Dave Chinner
Principal Engineer
SGI Australian Software Group
next prev parent reply other threads:[~2007-06-07 7:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-07 7:03 review: xfs_growfs_data_private() not logging agf length change Tim Shimmin
2007-06-07 7:30 ` David Chinner [this message]
2007-06-07 12:18 ` Christoph Hellwig
2007-06-07 12:49 ` David Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070607073034.GP86004887@sgi.com \
--to=dgc@sgi.com \
--cc=tes@sgi.com \
--cc=xfs-dev@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox