* review: xfs_growfs_data_private() not logging agf length change
@ 2007-06-07 7:03 Tim Shimmin
2007-06-07 7:30 ` David Chinner
0 siblings, 1 reply; 4+ messages in thread
From: Tim Shimmin @ 2007-06-07 7:03 UTC (permalink / raw)
To: xfs-dev; +Cc: xfs
[-- Attachment #1: Type: text/plain, Size: 686 bytes --]
Looks like we forgot to log the agf_length change here.
(cut 'n' pasted patch)
--Tim
===========================================================================
Index: fs/xfs/xfs_fsops.c
===========================================================================
--- a/fs/xfs/xfs_fsops.c 2007-04-17 18:02:46.000000000 +1000
+++ b/fs/xfs/xfs_fsops.c 2007-04-17 17:59:44.467987572 +1000
@@ -328,6 +328,7 @@ xfs_growfs_data_private(
be32_add(&agf->agf_length, new);
ASSERT(be32_to_cpu(agf->agf_length) ==
be32_to_cpu(agi->agi_length));
+ xfs_alloc_log_agf(tp, bp, XFS_AGF_LENGTH);
/*
* Free the new space.
*/
[-- Attachment #2: agf_length.patch --]
[-- Type: text/plain, Size: 388 bytes --]
--- .pc/agf_length.patch/fs/xfs/xfs_fsops.c 2007-06-07 16:19:27.000000000 +1000
+++ fs/xfs/xfs_fsops.c 2007-06-07 16:23:41.302363734 +1000
@@ -332,6 +332,7 @@ xfs_growfs_data_private(
be32_add(&agf->agf_length, new);
ASSERT(be32_to_cpu(agf->agf_length) ==
be32_to_cpu(agi->agi_length));
+ xfs_alloc_log_agf(tp, bp, XFS_AGF_LENGTH);
/*
* Free the new space.
*/
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: review: xfs_growfs_data_private() not logging agf length change
2007-06-07 7:03 review: xfs_growfs_data_private() not logging agf length change Tim Shimmin
@ 2007-06-07 7:30 ` David Chinner
2007-06-07 12:18 ` Christoph Hellwig
0 siblings, 1 reply; 4+ messages in thread
From: David Chinner @ 2007-06-07 7:30 UTC (permalink / raw)
To: Tim Shimmin; +Cc: xfs-dev, xfs
On Thu, Jun 07, 2007 at 05:03:11PM +1000, Tim Shimmin wrote:
> Looks like we forgot to log the agf_length change here.
>
> (cut 'n' pasted patch)
>
> --Tim
>
> ===========================================================================
> Index: fs/xfs/xfs_fsops.c
> ===========================================================================
>
> --- a/fs/xfs/xfs_fsops.c 2007-04-17 18:02:46.000000000 +1000
> +++ b/fs/xfs/xfs_fsops.c 2007-04-17 17:59:44.467987572 +1000
> @@ -328,6 +328,7 @@ xfs_growfs_data_private(
> be32_add(&agf->agf_length, new);
> ASSERT(be32_to_cpu(agf->agf_length) ==
> be32_to_cpu(agi->agi_length));
> + xfs_alloc_log_agf(tp, bp, XFS_AGF_LENGTH);
> /*
> * Free the new space.
> */
Yup, looks ok to me.
Cheers,
Dave.
--
Dave Chinner
Principal Engineer
SGI Australian Software Group
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: review: xfs_growfs_data_private() not logging agf length change
2007-06-07 7:30 ` David Chinner
@ 2007-06-07 12:18 ` Christoph Hellwig
2007-06-07 12:49 ` David Chinner
0 siblings, 1 reply; 4+ messages in thread
From: Christoph Hellwig @ 2007-06-07 12:18 UTC (permalink / raw)
To: David Chinner; +Cc: Tim Shimmin, xfs-dev, xfs
On Thu, Jun 07, 2007 at 05:30:34PM +1000, David Chinner wrote:
> On Thu, Jun 07, 2007 at 05:03:11PM +1000, Tim Shimmin wrote:
> > Looks like we forgot to log the agf_length change here.
> >
> > (cut 'n' pasted patch)
> >
> > --Tim
> >
> > ===========================================================================
> > Index: fs/xfs/xfs_fsops.c
> > ===========================================================================
> >
> > --- a/fs/xfs/xfs_fsops.c 2007-04-17 18:02:46.000000000 +1000
> > +++ b/fs/xfs/xfs_fsops.c 2007-04-17 17:59:44.467987572 +1000
> > @@ -328,6 +328,7 @@ xfs_growfs_data_private(
> > be32_add(&agf->agf_length, new);
> > ASSERT(be32_to_cpu(agf->agf_length) ==
> > be32_to_cpu(agi->agi_length));
> > + xfs_alloc_log_agf(tp, bp, XFS_AGF_LENGTH);
> > /*
> > * Free the new space.
> > */
>
> Yup, looks ok to me.
Except for the whitespace damage, of course - but that might have been
the cut & pasting.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: review: xfs_growfs_data_private() not logging agf length change
2007-06-07 12:18 ` Christoph Hellwig
@ 2007-06-07 12:49 ` David Chinner
0 siblings, 0 replies; 4+ messages in thread
From: David Chinner @ 2007-06-07 12:49 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: David Chinner, Tim Shimmin, xfs-dev, xfs
On Thu, Jun 07, 2007 at 01:18:53PM +0100, Christoph Hellwig wrote:
> On Thu, Jun 07, 2007 at 05:30:34PM +1000, David Chinner wrote:
> > On Thu, Jun 07, 2007 at 05:03:11PM +1000, Tim Shimmin wrote:
> > > Looks like we forgot to log the agf_length change here.
> > >
> > > (cut 'n' pasted patch)
> > >
> > > --Tim
.....
> >
> > Yup, looks ok to me.
>
> Except for the whitespace damage, of course - but that might have been
> the cut & pasting.
The attached patch had no ws damage. ;)
Cheers,
Dave.
--
Dave Chinner
Principal Engineer
SGI Australian Software Group
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-06-07 12:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-06-07 7:03 review: xfs_growfs_data_private() not logging agf length change Tim Shimmin
2007-06-07 7:30 ` David Chinner
2007-06-07 12:18 ` Christoph Hellwig
2007-06-07 12:49 ` David Chinner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox