From: David Chinner <dgc@sgi.com>
To: Christoph Hellwig <hch@lst.de>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] use filldir internally
Date: Fri, 8 Jun 2007 09:27:16 +1000 [thread overview]
Message-ID: <20070607232716.GK85884050@sgi.com> (raw)
In-Reply-To: <20070604143958.GB9081@lst.de>
On Mon, Jun 04, 2007 at 04:39:58PM +0200, Christoph Hellwig wrote:
> Currently xfs has a rather complicated internal scheme to allow for
> different directory formats in IRIX. This patch rips all code related
> to this out and pushes useage of the Linux filldir callback into the
> lowlevel directory code. This does not make the code any less portable
> because filldir can be used to create dirents of all possible variations
> (including the IRIX ones as proved by the IRIX binary emulation code
> under arch/mips/).
>
> This patch get rid of an unessecary copy in the readdir path, about
> 250 lines of code and one of the last two users of the uio structure.
Looks like a nice cleanup at a quick glance, but I need to spend more time
looking at it which I don't have right now. I'll add it to my QA in the
meantime....
Cheers,
Dave.
--
Dave Chinner
Principal Engineer
SGI Australian Software Group
next prev parent reply other threads:[~2007-06-07 23:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-04 14:39 [PATCH] use filldir internally Christoph Hellwig
2007-06-07 23:27 ` David Chinner [this message]
2007-06-08 0:20 ` David Chinner
2007-06-08 0:39 ` David Chinner
-- strict thread matches above, loose matches on Subject: below --
2007-07-29 21:13 Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070607232716.GK85884050@sgi.com \
--to=dgc@sgi.com \
--cc=hch@lst.de \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox