From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: with ECARTIS (v1.0.0; list xfs); Thu, 07 Jun 2007 16:27:29 -0700 (PDT) Received: from larry.melbourne.sgi.com (larry.melbourne.sgi.com [134.14.52.130]) by oss.sgi.com (8.12.10/8.12.10/SuSE Linux 0.7) with SMTP id l57NROWt027299 for ; Thu, 7 Jun 2007 16:27:25 -0700 Date: Fri, 8 Jun 2007 09:27:16 +1000 From: David Chinner Subject: Re: [PATCH] use filldir internally Message-ID: <20070607232716.GK85884050@sgi.com> References: <20070604143958.GB9081@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070604143958.GB9081@lst.de> Sender: xfs-bounce@oss.sgi.com Errors-to: xfs-bounce@oss.sgi.com List-Id: xfs To: Christoph Hellwig Cc: xfs@oss.sgi.com On Mon, Jun 04, 2007 at 04:39:58PM +0200, Christoph Hellwig wrote: > Currently xfs has a rather complicated internal scheme to allow for > different directory formats in IRIX. This patch rips all code related > to this out and pushes useage of the Linux filldir callback into the > lowlevel directory code. This does not make the code any less portable > because filldir can be used to create dirents of all possible variations > (including the IRIX ones as proved by the IRIX binary emulation code > under arch/mips/). > > This patch get rid of an unessecary copy in the readdir path, about > 250 lines of code and one of the last two users of the uio structure. Looks like a nice cleanup at a quick glance, but I need to spend more time looking at it which I don't have right now. I'll add it to my QA in the meantime.... Cheers, Dave. -- Dave Chinner Principal Engineer SGI Australian Software Group