From: David Chinner <dgc@sgi.com>
To: Christoph Hellwig <hch@lst.de>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] get rid of file_count abuse
Date: Fri, 8 Jun 2007 16:24:30 +1000 [thread overview]
Message-ID: <20070608062430.GY86004887@sgi.com> (raw)
In-Reply-To: <20070604143352.GA8721@lst.de>
On Mon, Jun 04, 2007 at 04:33:52PM +0200, Christoph Hellwig wrote:
> A check for file_count is always a bad idea. Linux has the ->release
> method to deal with cleanups on last close and ->flush is only for the
> very rare case where we want to perform an operation on every drop of
> a reference to a file struct.
*nod*
> This patch gets rid of vop_close and surrounding code in favour of
> simply doing the page flushing from ->release.
Added to my qa tree, and mangled to move the filestreams stuff from
xfs_close to xfs_release as well.
Thanks, Christoph.
Cheers,
Dave.
--
Dave Chinner
Principal Engineer
SGI Australian Software Group
prev parent reply other threads:[~2007-06-08 6:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-04 14:33 [PATCH] get rid of file_count abuse Christoph Hellwig
2007-06-08 6:24 ` David Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070608062430.GY86004887@sgi.com \
--to=dgc@sgi.com \
--cc=hch@lst.de \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox