Re: [PATCH 4/7][TAKE5] support new modes in fallocate

Andreas Dilger
2007-07-12T14:41:17Z

On Jul 12, 2007 13:56 +0530, Amit K. Arora wrote:
> As you suggest, let us just have two modes for the time being:
>
> #define FALLOC_ALLOCATE 0x1
> #define FALLOC_ALLOCATE_KEEP_SIZE 0x2
>
> As the name suggests, when FALLOC_ALLOCATE_KEEP_SIZE mode is passed it
> will result in file size not being changed even if the preallocation is
> beyond EOF.

What does FALLOC_ALLOCATE mean vs. not passing this flag? I have no
objection to this as long as the code remains with these as "flags"
instead of "modes"... Essentially just dropping the FALLOC_FL_DEALLOCATE
and FALLOC_FL_DEL_DATA from the interface.

Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.