From: Christoph Hellwig <hch@infradead.org>
To: David Chinner <dgc@sgi.com>
Cc: xfs-dev <xfs-dev@sgi.com>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: Review: Multi-File Data Streams V2
Date: Sat, 16 Jun 2007 21:38:51 +0100 [thread overview]
Message-ID: <20070616203851.GA7817@infradead.org> (raw)
In-Reply-To: <20070613041629.GI86004887@sgi.com>
Thanks, this version looks a lot better now.
The pip checks in xfs_inode.c are still in, but I'm pretty sure they're
not nessecary, and even if they were nessecary they'd need a good comment
explaining why.
The patch still hooks into xfs_close despite your comment that you
updated it for the removal of it.
I still strongly believe the mru cache should not be inside xfs. It's
a completely generic library function and should go into lib/ so it's
available to all of the kernel. That means it'll need some codingstyle
updates and proper kerneldoc comments, though.
next prev parent reply other threads:[~2007-06-16 20:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-13 4:16 Review: Multi-File Data Streams V2 David Chinner
2007-06-16 20:38 ` Christoph Hellwig [this message]
2007-06-18 1:47 ` David Chinner
2007-06-22 8:44 ` Timothy Shimmin
2007-06-25 3:53 ` David Chinner
2007-06-26 12:16 ` Tim Shimmin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070616203851.GA7817@infradead.org \
--to=hch@infradead.org \
--cc=dgc@sgi.com \
--cc=xfs-dev@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox