From: dgc@sgi.com (David Chinner)
To: sgi.bugs.xfs@engr.sgi.com
Cc: xfs@oss.sgi.com
Subject: TAKE 966562 - XFS should not be looking at filp reference counts
Date: Wed, 20 Jun 2007 15:48:58 +1000 (EST) [thread overview]
Message-ID: <20070620054858.99AD658C38F1@chook.melbourne.sgi.com> (raw)
XFS should not be looking at filp reference counts
A check for file_count is always a bad idea. Linux has the ->release
method to deal with cleanups on last close and ->flush is only for the
very rare case where we want to perform an operation on every drop of
a reference to a file struct.
This patch gets rid of vop_close and surrounding code in favour of
simply doing the page flushing from ->release.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Date: Wed Jun 20 15:48:18 AEST 2007
Workarea: chook.melbourne.sgi.com:/build/dgc/isms/2.6.x-xfs
Inspected by: hch@lst.de
The following file(s) were checked into:
longdrop.melbourne.sgi.com:/isms/linux/2.6.x-xfs-melb
Modid: xfs-linux-melb:xfs-kern:28952a
fs/xfs/xfs_vnodeops.c - 1.700 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_vnodeops.c.diff?r1=text&tr1=1.700&r2=text&tr2=1.699&f=h
- Move the functionality in xfs_close to xfs_release and
remove xfs_close.
fs/xfs/linux-2.6/xfs_file.c - 1.149 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/linux-2.6/xfs_file.c.diff?r1=text&tr1=1.149&r2=text&tr2=1.148&f=h
- Kill xfs_file_flush as xfs_file_release provides us with
the required last-close callout.
fs/xfs/linux-2.6/xfs_vnode.h - 1.128 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/linux-2.6/xfs_vnode.h.diff?r1=text&tr1=1.128&r2=text&tr2=1.127&f=h
- Remove the last close vop call as it is no longer needed.
reply other threads:[~2007-06-20 5:49 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070620054858.99AD658C38F1@chook.melbourne.sgi.com \
--to=dgc@sgi.com \
--cc=sgi.bugs.xfs@engr.sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox