public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
* TAKE 966562 - XFS should not be looking at filp reference counts
@ 2007-06-20  5:48 David Chinner
  0 siblings, 0 replies; only message in thread
From: David Chinner @ 2007-06-20  5:48 UTC (permalink / raw)
  To: sgi.bugs.xfs; +Cc: xfs

XFS should not be looking at filp reference counts

A check for file_count is always a bad idea.  Linux has the ->release
method to deal with cleanups on last close and ->flush is only for the
very rare case where we want to perform an operation on every drop of
a reference to a file struct.

This patch gets rid of vop_close and surrounding code in favour of
simply doing the page flushing from ->release.


Signed-off-by: Christoph Hellwig <hch@lst.de>

Date:  Wed Jun 20 15:48:18 AEST 2007
Workarea:  chook.melbourne.sgi.com:/build/dgc/isms/2.6.x-xfs
Inspected by:  hch@lst.de

The following file(s) were checked into:
  longdrop.melbourne.sgi.com:/isms/linux/2.6.x-xfs-melb


Modid:  xfs-linux-melb:xfs-kern:28952a
fs/xfs/xfs_vnodeops.c - 1.700 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_vnodeops.c.diff?r1=text&tr1=1.700&r2=text&tr2=1.699&f=h
	- Move the functionality in xfs_close to xfs_release and
	  remove xfs_close.

fs/xfs/linux-2.6/xfs_file.c - 1.149 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/linux-2.6/xfs_file.c.diff?r1=text&tr1=1.149&r2=text&tr2=1.148&f=h
	- Kill xfs_file_flush as xfs_file_release provides us with
	  the required last-close callout.

fs/xfs/linux-2.6/xfs_vnode.h - 1.128 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/linux-2.6/xfs_vnode.h.diff?r1=text&tr1=1.128&r2=text&tr2=1.127&f=h
	- Remove the last close vop call as it is no longer needed.

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2007-06-20  5:49 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-06-20  5:48 TAKE 966562 - XFS should not be looking at filp reference counts David Chinner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox