public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: David Chinner <dgc@sgi.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] remove hard-coded fnames from tracing functions
Date: Mon, 25 Jun 2007 20:49:14 +1000	[thread overview]
Message-ID: <20070625104914.GB31489@sgi.com> (raw)
In-Reply-To: <467F4A2F.2060101@sandeen.net>

On Sun, Jun 24, 2007 at 11:53:03PM -0500, Eric Sandeen wrote:
> Eric Sandeen wrote:
> > This has been on my stack a while, still compiles clean but feel free
> > to double-check. :-)
> > 
> >  xfs_alloc.c      |   53 ++--------
> >  xfs_bmap.c       |  266 +++++++++++++++++++++++--------------------------------
> >  xfs_bmap.h       |    6 -
> >  xfs_bmap_btree.c |   88 +++---------------
> >  xfs_inode.c      |    8 -
> >  5 files changed, 149 insertions(+), 272 deletions(-)
> > 
> > ---------------
> > 
> > Remove the hardcoded "fnames" for tracing, and just embed
> > them in tracing macros via __FUNCTION__.  Kills a lot of #ifdefs
> > too.
> 
> Hm... guess I did send this one already, but don't see it in cvs...
> Dave, is it in your stack yet?

<sigh>

It got as far as my incoming directory. I even remember reviewing it,
and then I forgot to import the patch. My bad.

I'll add it now.

Cheers,

Dave.
-- 
Dave Chinner
Principal Engineer
SGI Australian Software Group

  reply	other threads:[~2007-06-25 10:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-25  4:46 [PATCH] remove hard-coded fnames from tracing functions Eric Sandeen
2007-06-25  4:53 ` Eric Sandeen
2007-06-25 10:49   ` David Chinner [this message]
2007-06-25  6:20 ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070625104914.GB31489@sgi.com \
    --to=dgc@sgi.com \
    --cc=sandeen@sandeen.net \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox