Re: [patch 3/3] Fix XFS_IOC_FSBULKSTAT{,_SINGLE} and XFS_IOC_FSINUMBERS in compat mode (try3)

David Chinner
2007-07-03T01:04:05Z

On Mon, Jul 02, 2007 at 05:05:09PM +0200, Michal Marek wrote:
> On Mon, Jul 02, 2007 at 11:40:34AM +0200, Michal Marek wrote:
> > David Chinner wrote:
> > > I think we can remove xfs_bulkstat_one_compat() completely by using
> > > the same method you used with the xfs_inumber_fmt functions.
> >
> > You mean xfs_ioc_bulkstat_compat() -> native xfs_bulkstat() -> native
> > xfs_bulkstat_one() -> a compat output formatter, so a
> > pointer-to-function passed to pointer-to-function? ;) I could (ab)use
> > the void *private_data arg which xfs_bulkstat passes unmodified to the
> > formatter; xfs_bulkstat_one() doesn't make use of it atm. I'll try it
> > and post the result in a while.
>
> Hi David, what about this one? It about 30 lines shorter now :)

Great. Added to my tree. I'll run some tests and then get it
pushed out to the git trees.

FWIW, I reordered the includes to match the order in most other XFS
files so that it didn't break when I added other patches to
the tree....

Cheers,

Dave.
--
Dave Chinner
Principal Engineer
SGI Australian Software Group