Re: [patch 1/3] Fix XFS_IOC_FSGEOMETRY_V1 in compat mode

Christoph Hellwig
2007-06-04T14:56:22Z

On Fri, Jun 01, 2007 at 02:39:48PM +1000, Timothy Shimmin wrote:
>
>
> --On 31 May 2007 11:26:15 PM +1000 David Chinner <dgc@sgi.com> wrote:
> >>Who would want to use XFS_IOC_FSGEOMETRY_V1?
> >>
> >>Okay it turns out a whole bunch of our xfs-cmds :-)
> >>(Such as xfsdump as Michal mentioned)
> >>On Sep/2002, Nathan changed a bunch of them to use v1.
> >> xfsprogs-2.3.0 (03 September 2002)
> >> - Several changes to geometry ioctl callers which will make
> >> the tools useable on older kernel versions too.
> >>So he did this so that new tools would work on the older kernels which
> >>didn't support the new geom version.
> >>So I guess we are stuck with v1 now.
> >
> >Not necessarily - we could change the tools to use v4, and if that
> >didn't exist, then try v1. That way we don't need to support v1 in
> >linux, and the tools still run on old kernels.....
> >
> The problem with that is the old tools won't run on new kernels.
> If you get a new kernel and use an old xfsdump then you are out of luck.
> Not sure if we want to require people to bump up to new userspace for this.

Yeah, we need to keep supporting this for a while. Fortunately this
compat handler is rather trivial.